Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set type="button" attribute for copy to clipboard plugin. #2593

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

alexsegura
Copy link
Contributor

Hi.

When using Prism + copy to clipboard inside a HTML form, the form is submitted when copying.
It's because by default the button is seen as a submit button.
Adding the type="button" attribute prevents this.

@mAAdhaTTah
Copy link
Member

Makes sense. Thanks for the contribution!

@mAAdhaTTah mAAdhaTTah merged commit f59a85f into PrismJS:master Oct 15, 2020
@alexsegura alexsegura deleted the input-type-button branch October 15, 2020 15:12
@alexsegura
Copy link
Contributor Author

🙌

@mAAdhaTTah is a new release planned anytime soon?

@RunDevelopment
Copy link
Member

@mAAdhaTTah I think a new release after #2584 might be a good idea. I'm waiting for a confirmation from @yetingli that all vulnerabilities have been fixed but I'm reasonably confident that there won't be many others because of #2590.

@mAAdhaTTah
Copy link
Member

@RunDevelopment I'm on board with that. We did a release recently, so maybe next one should be a patch?

@RunDevelopment
Copy link
Member

@mAAdhaTTah Yeah. All commits since v1.22.0 were enhancements and bug fixes, so I agree that it should be a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants