-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS: Add support for Sass modules #2643
Merged
RunDevelopment
merged 1 commit into
PrismJS:master
from
adamkudrna:sass-modules-support
Nov 23, 2020
Merged
SCSS: Add support for Sass modules #2643
RunDevelopment
merged 1 commit into
PrismJS:master
from
adamkudrna:sass-modules-support
Nov 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @adamkudrna!
One small nit and this is ready to go.
RunDevelopment
added
enhancement
language-definitions
needs review
needs changes
and removed
needs review
labels
Nov 20, 2020
adamkudrna
force-pushed
the
sass-modules-support
branch
from
November 23, 2020 17:27
0bd091a
to
9336cf7
Compare
RunDevelopment
approved these changes
Nov 23, 2020
adamkudrna
added a commit
to frontend-garden/frontend-garden-ghost-theme
that referenced
this pull request
Jan 4, 2021
adamkudrna
added a commit
to frontend-garden/frontend-garden-ghost-theme
that referenced
this pull request
Jan 4, 2021
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to support Sass modules that look like this (showing missing support in the screenshots):