ESLint: Added indent rule #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the indent rule to enforce tabs throughout the codebase.
Since the indent rule will use tabs to align merged variables declarations, I also added the rule one-var to disallow merged variables declarations. This is an easy way to get around the whole smart-tabs problem. You can see this working in
plugins/autolinker/prism-autolinker.jsand other files.The reason this PR changes so many lines is that we had a few files (notably
prism-core.js) where the IIFE wasn't indented. However, requiring IIFE's to not be indented changes even more lines.