-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: add hoon programming language #2978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @matildepark!
Please fix the linting error and make the tests pass.
One reason that the tests don't pass is that you used capturing groups extensively. Except in the case of lookbehinds, you can replace all capturing groups with non-capturing groups. This should fix most of the problems our tests find.
Also, please add language tests for Hoon. We regularly improve our matching algorithm and tooling. Language tests are essential to make sure that nothing breaks. Please add tests that cover every regex in Hoon.
Step 6 in this guide explains how to add tests. For a more detailed explanation, see the test suite documentation.
If you run into problems or have any questions, feel free to ask anytime. I'm here to help.
Should resolve, I think — @RunDevelopment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor suggestions and I think I found a bug.
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Discussion in #2978
I believe everything addressed again; it's failing a test on identifiers, which I'm a little confused about; you can't name something |
Oh, right, I also reverted the change in 3982e75 because it was a broken definition. |
Indeed. I'll make a new suggestion. |
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Yeah, just exclude it here. I think you only need to disable |
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Oh, lol, it's because I changed it to function-name. OK, one sec ... |
You can let the test runner update all tests with |
Nice, tests pass. Just an |
Built! |
Thank you @matildepark! It's ready as is but we are currently fixing 2 bugs that came up after the last release. I'll merge this PR right after the patch for these 2 bugs is released, maybe in 1 or 2 days. |
No worries, thanks for the patience. |
Thank you for contributing @matildepark! |
We're using this downstream on https://urbit.org (in a site using next.js and remark-prism), so passing this language definition upstream. Derived from our tmLanguage definition and the documentation.