-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Odin #3280
Closed
Closed
Added support for Odin #3280
+1,044
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That you for the PR @edukisto!
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Address review comments
RunDevelopment
approved these changes
Mar 28, 2022
Please resolve the merge conflicts, and then we can merge this. Do the following steps:
This should work. Don't be surprised by any minified files changing. We recently switched to a different minifier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3204.
I think, the only pattern that can be inherited from
clike
isfunction
.I see no point in highlighting the names of built-in procedures (
abs
,align_of
,u128le
, etc.), since they are ordinary shadowable identifiers.The manual explicitly defines brackets and parentheses as operators. I’ll move them to the punctuation section if you like.
I’ve added the following features which present both in the compiler and @gingerBill’s post, but remain undocumented:
asm
keyword;0d
,0h
, and0z
number prefixes;j
andk
number suffixes.No nested multiline comments :( See
tests/languages/odin/failed_multiline_comment_feature.test
.