-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Gradle #3443
Add support for Gradle #3443
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +721 B (+29.9%).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @zeabdelkhalek!
It seems like you based this language of Groovy. That's obviously a good choice, but please adjust the tests. It seems like most of them have just been copied over, so please adjust them. Btw, to update tests quickly, just run npm run test:languages -- --update
.
Also, code style. Please copy the code style from languages. npm run lint:fix
is probably a good start.
@RunDevelopment I have made the necessary changes, could you check again please? |
@RunDevelopment fixed, can you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few minor things, but otherwise it's good to go.
Also, please run npm run build
to update the minified files.
@RunDevelopment can you check again? |
Thank you for contributing @zeabdelkhalek! |
This resolves #3353