Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for TabbedPage.Current in OnNavTo/From #2577

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add null check for TabbedPage.Current in OnNavTo/From #2577

merged 2 commits into from
Oct 7, 2021

Conversation

brianlagunas
Copy link
Member

Description of Change

Added a null check for the TabbedPage.Current in both the OnNvigatedTo and OnNavigatedFrom methods in the NavigatinService to prevent a null exception when testing with a blank TabbedPage

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas brianlagunas merged commit 16b18e9 into master Oct 7, 2021
@brianlagunas brianlagunas deleted the issue-2576 branch October 7, 2021 19:32
@dansiegel dansiegel mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianlagunas @dansiegel