Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send skin data, protocol updates #88

Merged
merged 8 commits into from
May 24, 2021
Merged

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented May 19, 2021

  • Skin data is now sent to server
  • Shield item ID is now set dynamically rather than being fixed in the protocol, a bit hacky
  • Fix an issue with empty chunks in proxy by sending chunks later

Fix #82
Fix #87

Tested on PocketMine 4, can confirm it's working with mineplex:

text {
  type: 'raw',
  needs_translation: false,
  source_name: undefined,
  message: '§r§7You §r§7have §r§7joined §r§7§fLobby-34§r§7. ',
  paramaters: undefined,
  xuid: '0',
  platform_chat_id: '0'
}

* Dynamic shield item id
* NBT reading/writing on void type uses 0 length, fix some third party servers
@extremeheat
Copy link
Member Author

Latest commit removes the global hack and sets root context variable now, through ProtoDef-io/node-protodef#125

When a server sends and client receives a StartGame packet with item palette, the parser/serializer is updated.

Currently since only the item structure requires SheildID, we only set that but in the future if it's an issue we can make a map and send it to the serialization code, eg setVariable('item', {shieldId: 255}), accessed via /item.shieldId. Avoided this for now to avoid possible issues for other non-js protodef implementations.

@extremeheat extremeheat merged commit f0fbf4f into PrismarineJS:master May 24, 2021
@extremeheat extremeheat mentioned this pull request May 24, 2021
@extremeheat extremeheat deleted the skins branch March 22, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when decoding packets when an entity moves Stuck on loading resources when connecting through proxy
1 participant