Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18+ Book editing feature #876

Merged
merged 4 commits into from
Jun 14, 2024
Merged

1.18+ Book editing feature #876

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69f3a16
Added feature for 1.18+ book editing packet
unlimitedcoder2 May 7, 2024
444cecb
Updated feature description for new book edit packet
unlimitedcoder2 May 7, 2024
140fc18
replace hasNonNbtEditBookPacket with editBookPacketUsesNbt
extremeheat Jun 1, 2024
8c44ead
Update features.json
extremeheat Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion data/pc/common/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,17 @@
},
{
"name": "hasEditBookPacket",
"description": "book editing is handled through a packet",
"description": "book editing is handled through a packet with the updated book item",
"versions": [
"1.13",
"1.17.1"
]
},
{
"name": "hasNonNbtEditBookPacket",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature naming is confusing here. Can you elaborate what exactly the difference in packet is before vs after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old edit book packet serializes the item and uses the nbt data from that
image

New packet sends the pages and title as packet fields
image

Copy link
Member

@extremeheat extremeheat May 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a new editBookPacketUsesNbt feature then (to match old versions)? This seems clearer than the current naming between hasEditBookPacket and hasNonNbtEditBookPacket, as there is actaully an edit book packet on both version ranges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"description": "book editing is handled through a packet with the pages and title",
"versions": [
"1.18",
"latest"
]
},
Expand Down
Loading