Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update biomes enum for MC 1.8 #197

Merged
merged 1 commit into from
Mar 13, 2015
Merged

Conversation

deathcap
Copy link
Member

MC 1.8 update for lib/enums/biomes.json (probably the simplest of the enums). Based on burger.json from https://github.com/deathcap/Burger/tree/mc18 through bin/generate_enums.java, with the following caveats:

@roblabla
Copy link
Member

Is this ready to merge ? It looks good. Concerning "modified biomes", I think whenever we get a biome from the server, doing a simple if (biome > 128) biome -= 128 might work. From what I read on the gamepedia, only the name changes.

@deathcap
Copy link
Member Author

👍 ok to merge (imho the modified biomes should be handled separately, since they inherit the same properties from this enum)

roblabla added a commit that referenced this pull request Mar 13, 2015
Update biomes enum for MC 1.8
@roblabla roblabla merged commit 359966a into PrismarineJS:master Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants