Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unused moduleMain code for browserify compatibility #4

Merged
merged 3 commits into from
Jan 10, 2016
Merged

Disable unused moduleMain code for browserify compatibility #4

merged 3 commits into from
Jan 10, 2016

Commits on Jan 10, 2016

  1. Add script to generate parser using jison

    @deathcap
    deathcap committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    cc77e29 View commit details
    Browse the repository at this point in the history

  2. Disable unused moduleMain code for browserify compatibility 

    The jison parser generator by default will generate a command-line
interface built into the parser. node-mojangson only uses the parser
object and not the command-line interface, and has no way to access it,
so it can be safely disabled -- since it causes compatibility issues
with some browserify transforms (and is unused), see:

zaach/jison#300
browserify/static-eval#12
    @deathcap
    deathcap committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    b81190e View commit details
    Browse the repository at this point in the history

  3. Update jison to use --moduleMain argument to exclude CLI tool

    @deathcap
    deathcap committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    fe5c633 View commit details
    Browse the repository at this point in the history