Add methods, fix .equals #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szdytom <szdytom@qq.com>
rom1504
reviewed
Oct 30, 2023
rom1504
reviewed
Oct 30, 2023
| /** | ||
| * Returns an array component x, z | ||
| */ | ||
| xz(): [number, number]; |
There was a problem hiding this comment.
Is that useful?
[p.x, p.z] seems clearer to use
There was a problem hiding this comment.
I think it can be useful, please consider a longer name like bot.entity.position.
Signed-off-by: szdytom <szdytom@qq.com>
szdytom
changed the title
rom1504
reviewed
Dec 17, 2023
Signed-off-by: szdytom <szdytom@qq.com>
|
/makerelease |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods:
.xz(),.xy(),.yz()for accessing interested parts only.xzy()for a vector with y and z swapped..at(index)a shortcut for.toArray()[index]isZero()checks for zero vectorChanged methods:
.equals(): Usually we can't use===for comparing two floats, which leads to0.1 + 0.2 !== 0.3..set(): Now we can pass null to those component we don't want to change.