Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copy of unchanged files #278

Closed
wants to merge 2 commits into from
Closed

Avoid copy of unchanged files #278

wants to merge 2 commits into from

Conversation

Saiv46
Copy link
Contributor

@Saiv46 Saiv46 commented Feb 8, 2022

It uses modified time of source and destination files (if exists) to filter out unchanged files from being copied on build.

Closes #210

@Saiv46
Copy link
Contributor Author

Saiv46 commented Feb 8, 2022

Module not found: Error: Can't resolve 'tls' in '/home/runner/work/prismarine-web-client/prismarine-web-client/node_modules/https-proxy-agent/dist'

The fuck? How my PRs breaking other webpack plugins in unexpected ways?

@rom1504
Copy link
Member

rom1504 commented Feb 8, 2022

I fixed the tls issue

@rom1504
Copy link
Member

rom1504 commented Feb 8, 2022

@KalmeMarq @AwesomestCode can you check if this works for you?

Things that should work:

  • npm start
  • npm run build

@rom1504
Copy link
Member

rom1504 commented Feb 13, 2022

this will get closed in 5 days if nobody tests it

@Saiv46
Copy link
Contributor Author

Saiv46 commented Mar 8, 2022

Tested with latest webpack

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "url": require.resolve("url/") }'
	- install 'url'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "url": false }
 @ ./node_modules/.pnpm/github.com+PrismarineJS+net-browserify@0acebf76d5a_5678e2fd34bc6a9aacd7b63820e4e40f/node_modules/net-browserify/browser.js 4:11-26
 @ ./index.js 11:12-26

@Saiv46
Copy link
Contributor Author

Saiv46 commented Mar 8, 2022

I still can't get build work with PNPM, while NPM installing packages slower on my new SSD

@AwesomestCode
Copy link
Member

AwesomestCode commented Mar 8, 2022

Quickly checked npm start on GitPod. It compiles successfully though some assets seem to be missing? Or my computer might just be weird.
Screenshot 2022-03-08 at 15 56 33

Edit: also tested on my Chromebook. Same issue, happens with npm run build-start too.

Confirmed that the issue does not happen on master.

@Saiv46
Copy link
Contributor Author

Saiv46 commented Apr 7, 2022

Closed in favor of #253

@Saiv46 Saiv46 closed this Apr 7, 2022
@Saiv46 Saiv46 deleted the patch-1 branch April 7, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Webpack faster
3 participants