LE-1096 | Add method full name based collections tagger for Kotlin #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
commented
Feb 20, 2024
src/main/scala/ai/privado/languageEngine/java/tagger/collection/CollectionTagger.scala
Show resolved
Hide resolved
ghost
commented
Feb 20, 2024
src/main/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTagger.scala
Outdated
Show resolved
Hide resolved
ghost
commented
Feb 20, 2024
...st/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
ghost
requested review from
khemrajrathore,
HiteshMah-Jan and
pandurangpatil
This comment was marked as resolved.
This comment was marked as resolved.
src/main/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTagger.scala
Outdated
Show resolved
Hide resolved
src/main/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTagger.scala
Outdated
Show resolved
Hide resolved
...st/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
ghost
commented
Feb 20, 2024
...la/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
.../scala/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTagger.scala
Outdated
Show resolved
Hide resolved
.../scala/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTagger.scala
Outdated
Show resolved
Hide resolved
ghost
commented
Feb 22, 2024
ghost
commented
Feb 22, 2024
ghost
commented
Feb 22, 2024
src/test/scala/ai/privado/languageEngine/java/AbstractTaggingSpec.scala
Outdated
Show resolved
Hide resolved
|
@khemrajrathore PR is ready for review. |
ghost
mentioned this pull request
...la/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
...la/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
...st/scala/ai/privado/languageEngine/kotlin/tagger/collection/KotlinCollectionTaggerTest.scala
Outdated
Show resolved
Hide resolved
.../scala/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTagger.scala
Outdated
Show resolved
Hide resolved
.../scala/ai/privado/languageEngine/java/tagger/collection/MethodFullNameCollectionTagger.scala
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Thank you @khemrajrathore, I will fix the points you've already mentioned and add more comments with code examples as well. |
added 21 commits
March 4, 2024 11:34
Test still remaining
Uses the Java collection tagger for deriving sources.
Need to investigate why.
…rces Tag not working, need to investigate
so that it can be easily reused
and fix Kotlin test
in cases where it is either a function invocation or its a static endpoint reference or a companion(kotlin) reference. TODO: the 'endpoint' is still not getting tagged in 'CollectionExporter'. This is to be debugged.
ghost
force-pushed
the
add_kotlin_collection_tagger
branch
from
fa8543d to
ce4afd6
Compare
ghost
requested review from
khemrajrathore
and removed request for
pandurangpatil and
HiteshMah-Jan
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue - https://privado-ai.atlassian.net/browse/LE-1096
Adds method full name collection tagging, derives from Java collection tagger for finding the sources.