-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the README.md
file
#172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of these sections could be moved to the wiki to keep the README simpler. I could make those page in the wiki and make a separate PR to delete the corresponding sections in the README, if that's okay?
### Use ppafm Docker container | ||
|
||
##### Example 3: Pyridine with Density-overlap | ||
We propose to use [Docker](https://docs.docker.com/get-docker/) to make the code platform-independent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we also plan to have wheels for all platforms, which should become the more straightforward installation option for every platform. Docker is useful to have as an option, but in order to keep the README minimal, maybe this should also be moved to the wiki page with additional installation options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you proposed to make follow-up PRs, will you take care of that too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll do it.
|
||
Once the simulation is finished, a number of files and folders will be created. | ||
|
||
### GUI usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this whole section to the wiki as well. The GUI needs more documentation anyway.
Co-authored-by: NikoOinonen <42408893+NikoOinonen@users.noreply.github.com>
Sure. In that case, nothing is left to do for the current PR. After this is merged, you can go ahead with the follow-ups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good.
Follow-up to #172. Fixed a couple of typos and relocated some of the additional instructions to two new wiki pages: https://github.com/Probe-Particle/ppafm/wiki/Additional-installation-instructions https://github.com/Probe-Particle/ppafm/wiki/PPAFM-GUI
fixes #86