Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the README.md file #172

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Improve the README.md file #172

merged 2 commits into from
Jun 13, 2023

Conversation

yakutovicha
Copy link
Collaborator

@yakutovicha yakutovicha commented Jun 13, 2023

fixes #86

Copy link
Collaborator

@NikoOinonen NikoOinonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these sections could be moved to the wiki to keep the README simpler. I could make those page in the wiki and make a separate PR to delete the corresponding sections in the README, if that's okay?

Comment on lines +46 to +48
### Use ppafm Docker container

##### Example 3: Pyridine with Density-overlap
We propose to use [Docker](https://docs.docker.com/get-docker/) to make the code platform-independent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we also plan to have wheels for all platforms, which should become the more straightforward installation option for every platform. Docker is useful to have as an option, but in order to keep the README minimal, maybe this should also be moved to the wiki page with additional installation options.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you proposed to make follow-up PRs, will you take care of that too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do it.


Once the simulation is finished, a number of files and folders will be created.

### GUI usage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this whole section to the wiki as well. The GUI needs more documentation anyway.

Co-authored-by: NikoOinonen <42408893+NikoOinonen@users.noreply.github.com>
@yakutovicha
Copy link
Collaborator Author

I think some of these sections could be moved to the wiki to keep the README simpler. I could make those page in the wiki and make a separate PR to delete the corresponding sections in the README, if that's okay?

Sure. In that case, nothing is left to do for the current PR. After this is merged, you can go ahead with the follow-ups.

@yakutovicha yakutovicha requested a review from NikoOinonen June 13, 2023 13:26
Copy link
Collaborator

@NikoOinonen NikoOinonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good.

@yakutovicha yakutovicha merged commit 7c9c8a6 into main Jun 13, 2023
@yakutovicha yakutovicha deleted the update/readme branch June 13, 2023 17:01
@NikoOinonen NikoOinonen mentioned this pull request Jun 14, 2023
NikoOinonen added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in the installaton description in README.md
2 participants