Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable flake8 pre-commit hook. #187

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

NikoOinonen
Copy link
Collaborator

I'm suggesting that we temporarily disable the flake8 pre-commit hook, since there has been no consensus on whether black should be enabled or not (#96). At the moment the pre-commit never succeeds because of all the code style problems, so it's mostly just an annoyance since in practice you have to use the --no-verify option every time or manually disable the check locally.

Copy link
Collaborator

@mondracek mondracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it. But we should reactivate it later when we are ready to review all the white-space formatting issues. Comparing and merging too branches that do not differ much but differ a lot in the white spaces is a hell.

@NikoOinonen NikoOinonen merged commit cc1f92b into main Aug 7, 2023
@NikoOinonen NikoOinonen deleted the disable-flake8 branch August 7, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants