Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pre-commit for the whole repository #222

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

yakutovicha
Copy link
Collaborator

@yakutovicha yakutovicha commented Oct 31, 2023

fixes #210

@yakutovicha yakutovicha force-pushed the chore/apply-pre-commit-everywhere branch from ea49ba7 to a02e617 Compare October 31, 2023 15:26
Copy link
Collaborator

@NikoOinonen NikoOinonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through everything in detail, but since it's just formatting changes, should be fine.

We should also remember to document the # fmt: on/off in the wiki, so maybe don't close #210 yet, or make a new issue for it.

@yakutovicha
Copy link
Collaborator Author

We should also remember to document the # fmt: on/off in the wiki, so maybe don't close #210 yet, or make a new issue for it.

I just did it, as it was quicker than making an issue.

@yakutovicha yakutovicha merged commit 7be706c into main Nov 2, 2023
@yakutovicha yakutovicha deleted the chore/apply-pre-commit-everywhere branch November 2, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol for dealing with formatting changes needed
2 participants