Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair in plot_results.py for IETS (still not fully working). #237

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ondrejkrejci
Copy link
Collaborator

There was one problem in plot_results.py, which is solved with this. Allows to run at least one IETS example, that we have on PPSTM.

The small change in the fastmath_light.h enables easier compilation from source on more platforms (at least it is working for me on my crazy Win machine without sudo).

And I have learned how the new formating and precommit things are working 👍 .

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a1a7a72) 46.82% compared to head (d8cb43d) 46.84%.

Files Patch % Lines
ppafm/cli/plot_results.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   46.82%   46.84%   +0.02%     
==========================================
  Files          32       35       +3     
  Lines        5143     5147       +4     
==========================================
+ Hits         2408     2411       +3     
- Misses       2735     2736       +1     
Flag Coverage Δ
python-3.10 46.85% <0.00%> (?)
python-3.11 46.82% <0.00%> (?)
python-3.12 46.82% <0.00%> (ø)
python-3.7 46.64% <0.00%> (?)
python-3.9 46.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ondrejkrejci
Copy link
Collaborator Author

I know that I have added/change that one line plot_results.py, but that one is reading data from the IETS procedure, which is not working. I am happy to add the full running of some full minor example, once we have the IETS procudes fully working,

Copy link
Collaborator

@NikoOinonen NikoOinonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ondrejkrejci ondrejkrejci merged commit 0f5795c into main Nov 15, 2023
@ondrejkrejci ondrejkrejci deleted the IETS_plotting_repair branch November 15, 2023 07:42
@NikoOinonen
Copy link
Collaborator

@yakutovicha Is it really the case that if you add a single line that is not tested, then it fails the CI test completely? I think this is maybe too strict of a requirement for every PR.

@yakutovicha
Copy link
Collaborator

@yakutovicha Is it really the case that if you add a single line that is not tested, then it fails the CI test completely? I think this is maybe too strict of a requirement for every PR.

There should be a setting for that. Sorry, I can't recall exactly how to change it. Feel free to update it.

@yakutovicha
Copy link
Collaborator

@NikoOinonen, I think I changed the threshold to 2%. Let's hope it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants