Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the FePc_Au-IETS example #262

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Adding the FePc_Au-IETS example #262

merged 1 commit into from
Feb 9, 2024

Conversation

ondrejkrejci
Copy link
Collaborator

Fixes #259

Just to have the IETS image in Fig 5 (b) in the examples easily achievable.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f26011) 46.44% compared to head (14cd5cd) 46.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files          35       35           
  Lines        5180     5180           
=======================================
  Hits         2406     2406           
  Misses       2774     2774           
Flag Coverage Δ
python-3.10 46.45% <ø> (ø)
python-3.11 46.42% <ø> (ø)
python-3.12 46.42% <ø> (ø)
python-3.7 46.25% <ø> (ø)
python-3.9 46.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mondracek
Copy link
Collaborator

@ondrejkrejci, the Evib*png and Kvib*png images (examples/FePc_Au-IETS/Evib_atoms_000.png and examples/FePc_Au-IETS/Kvib_atoms_000.png) look virtually identical. Is that to be expected?

@ondrejkrejci
Copy link
Collaborator Author

@ondrejkrejci, the Evib*png and Kvib*png images (examples/FePc_Au-IETS/Evib_atoms_000.png and examples/FePc_Au-IETS/Kvib_atoms_000.png) look virtually identical. Is that to be expected?

Wow, you have tried those. Good job 👍 . At one point, I thought, that the images were uploaded there (which I did not want). Yes, the contrast expected to be the same, but the scale and units are different. Please see:

e_vib = common.HBAR * np.sqrt((common.eVA_Nm * eigenvalue_k) / (iets_m * common.AUMASS))

My guess, that to plot both of those, it is comming to historical reasons (Kvib is the first thing that you want to check) and potentially due to the advanced version of IETS that is comming to https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.119.166001 where we needed the frequency. But to be honnest I do not remember exactly. As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.

@mondracek
Copy link
Collaborator

Wow, you have tried those.

Well @ondrejkrejci , I've got e-mail from GitHub that you explicitly asked me for review, so... You're welcome.

@ondrejkrejci ondrejkrejci merged commit 279214a into main Feb 9, 2024
14 checks passed
@ondrejkrejci ondrejkrejci deleted the fepc_example branch February 9, 2024 17:10
@ProkopHapala
Copy link
Collaborator

I personally feel that this is not worth of it.

As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.

Commentig out saving xsf file is not "pretty complex", if we have clear idea what is better to plot?

  • K_vib is nice for rationalization of the results because you can compare it directly to the simulation parameters (K_lat, K_rad of the tip)
  • e_vib is more relevant to the experiment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the FePc example to the examples
3 participants