-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the FePc_Au-IETS example #262
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 35 35
Lines 5180 5180
=======================================
Hits 2406 2406
Misses 2774 2774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ondrejkrejci, the |
Wow, you have tried those. Good job 👍 . At one point, I thought, that the images were uploaded there (which I did not want). Yes, the contrast expected to be the same, but the scale and units are different. Please see: ppafm/ppafm/cli/plot_results.py Line 158 in 6f26011
My guess, that to plot both of those, it is comming to historical reasons (Kvib is the first thing that you want to check) and potentially due to the advanced version of IETS that is comming to https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.119.166001 where we needed the frequency. But to be honnest I do not remember exactly. As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it. |
Well @ondrejkrejci , I've got e-mail from GitHub that you explicitly asked me for review, so... You're welcome. |
Commentig out saving xsf file is not "pretty complex", if we have clear idea what is better to plot?
|
Fixes #259
Just to have the IETS image in Fig 5 (b) in the examples easily achievable.