Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env for disabling telescope #2393

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Add env for disabling telescope #2393

merged 1 commit into from
Oct 7, 2019

Conversation

nolanpro
Copy link
Contributor

Fixes #2371

No changes were needed to the service provider since telescope already looks for TELESCOPE_ENABLED env var.

Note that telescope will log its own events until this fix is released.

@nolanpro nolanpro requested a review from velkymx September 17, 2019 22:20
@ryancooley ryancooley added the hold Issue is blocked or put on hold label Sep 26, 2019
@velkymx velkymx removed the hold Issue is blocked or put on hold label Oct 7, 2019
@velkymx velkymx merged commit f995989 into develop Oct 7, 2019
@velkymx velkymx deleted the feature/2371 branch August 10, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velkymx velkymx velkymx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telescope enable via ENV
3 participants
@nolanpro @velkymx @ryancooley