Add process categories #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velkymx
suggested changes
Aug 23, 2018
| @@ -7,40 +7,49 @@ | |||
| use ProcessMaker\Exception\ValidationException; | |||
There was a problem hiding this comment.
Let's remove this manager completely. Move the validation rules into the model and the business logic into the controller.
| @@ -22,13 +22,17 @@ class ProcessCategory extends Model | |||
| use ValidatingTrait; | |||
| use Uuid; | |||
|
|
|||
| const STATUS_ACTIVE = 'ACTIVE'; | |||
| const STATUS_INACTIVE = 'INACTIVE'; | |||
|
|
|||
| /** | |||
| * Validation rules. | |||
| * | |||
| * @var array $rules | |||
| */ | |||
| protected $rules = [ | |||
There was a problem hiding this comment.
Make the rules public so we can use them in the controller.
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Database\Migrations\Migration; | ||
|
|
||
| class AddStatusToProcessCategoriesTable extends Migration |
There was a problem hiding this comment.
Replace the current migration completely. Don't add an additional migration.
|
@nolanpro when editing a category the alert message shows "New Category Successfully Created" should say Category Updated Successfully |
|
Ok should be fixed |
velkymx
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#537
In addition to adding the basic UI and crud stuff, this also refactors and cleans up a bunch of things.
No jest tests yet since I'm looking into a babel transform issue and this