Add support for Rails 5.2 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails removed the second argument to the ActiveRecord::WhereClause class This fixes it to work for Rails 5.2 Change was made in Rails 5.2 in this commit on Rails: rails/rails@213796f#diff-c9d167bac00ff2f45c5b5e035e8a80e8
onesneakymofo
approved these changes
Dec 4, 2018
| @@ -39,7 +39,12 @@ module WhereMethods | |||
| end | |||
| memo | |||
| end | |||
| if ActiveRecord::VERSION::STRING > '5' | |||
| if ActiveRecord::VERSION::STRING >= '5.2' | |||
There was a problem hiding this comment.
I'd rather not make this change here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails refactored their private WhereClause class to only accept one argument. This removes the second argument so that it will work properly.