Fix overwriting of HASH_DATA_COLUMNS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scope HASH_DATA_COLUMNS to the class where it's include instead of letting there be a hash that gets overwritten
dwilkins
force-pushed
the
bug/fix-hash-data-columns-overwrite
branch
22 times, most recently
from
7d94c34 to
cbb882b
Compare
- Also updating bundler to 2.0.2 - add manifest file for new sprockets
dwilkins
force-pushed
the
bug/fix-hash-data-columns-overwrite
branch
from
cbb882b to
80b28be
Compare
dwilkins
changed the title
Tetramputechture
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HASH_DATA_COLUMNSis being overwritten if other classes where squint is used have a column of the same name.Fix:
HASH_DATA_COLUMNSto the class where it's included instead of letting there be a hash that gets overwrittenSince the CircleCI config was old, several other changes were required:
circleci.ymlbundlerto 2.0.2Note for testers
For those running the tests in an existing dev environment:
bundle exec rake --rakefile test/dummy/Rakefile db:setupbundle exec rake testI removed
prywhile furiously attempting to get CircleCI to run again. Maybe we can add those back at some point.manifest.jswas added because of a sprockets change:rails/sprockets-rails#444