Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added better error handling #13

Merged
merged 23 commits into from
May 4, 2022
Merged

Added better error handling #13

merged 23 commits into from
May 4, 2022

Conversation

emilrl-gh
Copy link
Contributor

Started replacing asserts with if statements to check for errors

@CRKatri
Copy link
Member

CRKatri commented Apr 4, 2022

Thanks for getting started on this.

CRKatri
CRKatri requested changes Apr 4, 2022
View reviewed changes
@CRKatri CRKatri linked an issue Apr 5, 2022 that may be closed by this pull request
Add proper error handling #12
Closed
@emilrl-gh
Copy link
Contributor Author

@CRKatri Should there be a version bump for Ldid once error checking is done?

CRKatri
CRKatri reviewed Apr 5, 2022
View reviewed changes
ldid.cpp Outdated

if (ca_ == NULL)
ca_ = sk_X509_new_null();
if(ca_ == NULL){
printf("An error occured while parsing: %s\n", ERR_error_string(ERR_get_error(), NULL));
printf("An error occured while parsing: \n %s\n", ERR_error_string(ERR_get_error(), NULL));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't re-add those newlines, I had removed them on purpose.

@CRKatri
Copy link
Member

CRKatri commented Apr 5, 2022

Should there be a version bump for Ldid once error checking is done?

That is the current plan.

@demhademha
Copy link

We should ideally use exit(EXIT_FAILURE);

@demhademha
Copy link

And EXIT_SUCCESS

@emilrl-gh
Copy link
Contributor Author

Should there be a version bump for Ldid once error checking is done?

That is the current plan.

What should the new version number be do you think?

@CRKatri
Copy link
Member

CRKatri commented Apr 5, 2022

Should there be a version bump for Ldid once error checking is done?

That is the current plan.

What should the new version number be do you think?

It will be 2.1.5-procursus3. The first number is the upstream version number from git.saurik.com/ldid.git. Then we do -procursus* to show the Procursus patch version.

@CRKatri CRKatri requested a review from 1Conan April 22, 2022 19:08
absidue
absidue suggested changes Apr 30, 2022
View reviewed changes
@CRKatri @absidue
Update ldid.cpp
59af21b 
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
@CRKatri CRKatri merged commit 51e674a into ProcursusTeam:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRKatri CRKatri CRKatri requested changes

@1Conan 1Conan 1Conan approved these changes

@absidue absidue absidue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proper error handling
6 participants
@emilrl-gh @CRKatri @demhademha @1Conan @NSAntoine @absidue