Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm version of CPUID #26

Open
ProgramMax opened this issue Aug 29, 2016 · 2 comments · Fixed by #134
Open

Arm version of CPUID #26

ProgramMax opened this issue Aug 29, 2016 · 2 comments · Fixed by #134
Labels
enhancement
Milestone
v1

Comments

@ProgramMax
Copy link
Owner

The CPUID code works for x86 using inline assembly and VC intrinsics.
But there is no CPUID code for ARM.
Add one.
@ProgramMax ProgramMax added this to the v1 milestone Aug 29, 2016
@ProgramMax ProgramMax self-assigned this Aug 29, 2016
@ProgramMax ProgramMax removed their assignment Jan 16, 2019
@ProgramMax
Copy link
Owner Author

The way ARM's CPUID works is completely different.
First off, the instruction is only available to the kernel. So we have to call a kernel function to get it.
Additionally, it doesn't operate on the leaf/subleaf idea.

What all this means is the CPUID section will need to be reworked significantly.

For now, let's just get max building on ARM.

ProgramMax added a commit that referenced this issue Jul 10, 2019
@ProgramMax
Fix ARM compiling
f94ab31 
This commit fixes the ARM compiles.

There is still work to be done to get parity to x86:
- The Vector unit tests fail because of the call to sqrt().
- The CPUID code needs to be reworked.

But this is progress in the right direction. :)

Partially fixes #26
@ProgramMax ProgramMax mentioned this issue Jul 10, 2019
Merged
ProgramMax added a commit that referenced this issue Jul 10, 2019
@ProgramMax
Fix ARM compiling
7cba017 
This commit fixes the ARM compiles.

There is still work to be done to get parity to x86:
- The Vector unit tests fail because of the call to sqrt().
- The CPUID code needs to be reworked.

But this is progress in the right direction. :)

Partially fixes #26
@ProgramMax ProgramMax reopened this Jul 10, 2019
@ProgramMax
Copy link
Owner Author

I didn't mean to close this.
Apparently writing "fixes ___" will close it once merged.
However, I had written "partially fixes ____".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Fix ARM compiling ProgramMax/max
1 participant
@ProgramMax