Skip to content

Commit

Permalink
Fix build + only Lint on push
Browse files Browse the repository at this point in the history
  • Loading branch information
marob committed May 6, 2024
1 parent df289d5 commit f246901
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Build and test
run-name: Building and testing branch ${{ github.ref }}
on: [push, pull_request]
on: [pull_request]
jobs:
build-frontend:
name: Build Frontend
Expand Down Expand Up @@ -36,7 +36,7 @@ jobs:
working-directory: ui/ui-frontend
- run: npm run build:allModules
working-directory: ui/ui-frontend
- run: npm run test:conf-ci
- run: npm run ci:test
working-directory: ui/ui-frontend
- run: npm run package:all
working-directory: ui/ui-frontend
Expand Down
25 changes: 25 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Lint
run-name: Linting branch ${{ github.ref }}
on: [push]
jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
# - uses: actions/setup-java@v4
# with:
# distribution: 'temurin'
# java-version: '11'
# cache: 'maven'
- uses: actions/setup-node@v4
with:
node-version: lts
- run: ./tools/check_icomoon.sh
# Only install prettier globally (with same version as in package.json)
- run: npm i -g prettier@$(jq -r '.devDependencies.prettier' package.json)
- run: npm run prettier:ci
working-directory: ui/ui-frontend-common
- run: npm run prettier:ci
working-directory: ui/ui-frontend
# FIXME: Add a lint for Java part

0 comments on commit f246901

Please sign in to comment.