Story #12096: Fix service registration when colocalisation with consul server. #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiooDev
added
bug
|
No New Or Fixed Issues Found |
lgheribi
reviewed
Dec 12, 2023
| @@ -3,6 +3,7 @@ spring: | |||
| cloud: | |||
| consul: | |||
| enabled: true | |||
| host: {{ hostvars[inventory_hostname][consul.network] if inventory_hostname in groups['hosts_vitamui_consul_server'] else 'localhost' }} | |||
There was a problem hiding this comment.
Je ne suis pas sûr de comprendre ni le soucis ni le fix 😄
La conf consul ne semble pas écouter sur localhost
https://github.com/ProgrammeVitam/vitam-ui/blob/story_12096_fix_consul_host_register/deployment/roles/consul/templates/consul.json.j2
Aussi, je ne sais pas si on est censé supporté le mode où vitamui est déployé sur une instance hébergeant également vitam : quel consul est utilisé / déployé dans ce cas?
GiooDev
force-pushed
the
story_12096_fix_consul_host_register
branch
from
9753e18 to
ad7d9a7
Compare
…l server. Consul server is not bind to localhost.
GiooDev
force-pushed
the
story_12096_fix_consul_host_register
branch
from
ad7d9a7 to
e454008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consul server is not bind to localhost.
Type de changement:
Contributeur