Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic #12041: Migration apps to API Gateway #1664

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Epic #12041: Migration apps to API Gateway #1664

merged 8 commits into from
Mar 4, 2024

Conversation

bbenaissa
Copy link
Collaborator

@bbenaissa bbenaissa commented Mar 1, 2024 •
edited by GiooDev
Loading

Description

L'objectif de cette US est :

  • La migration des applications suivantes vers le mode API Gateway:

    • Versements des archives
    • Recherche et consultations des archives.
    • Collecte et préparation des versements
    • Profils documentaires

  • Prise en compte du mode d'authentification LDAP avec le mode API Gateway

Type de changement

  • Build

  • Ansiblerie

Tests

manuel

environnement

Contributeur

  • VAS (Vitam Accessible en Service)

@bbenaissa bbenaissa self-assigned this Mar 1, 2024
@bbenaissa bbenaissa added enhancement New feature or request VAS VAS contribution OPS REVIEW Mandatory if deployment/ directory is modified. labels Mar 1, 2024
@bbenaissa bbenaissa added this to the IT 132 milestone Mar 1, 2024
@bbenaissa bbenaissa marked this pull request as ready for review March 1, 2024 17:27
@vitam-devops
Copy link
Collaborator

vitam-devops commented Mar 1, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – ff39e5dd-346a-408f-be15-c0afde00674a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unchecked_Input_for_Loop_Condition /api/api-collect/collect-external/src/main/java/fr/gouv/vitamui/collect/external/server/rest/TransactionArchiveUnitExternalController.java: 95 Attack Vector
MEDIUM Unchecked_Input_for_Loop_Condition /api/api-archive-search/archive-search-external/src/main/java/fr/gouv/vitamui/archives/search/external/server/rest/ArchivesSearchExternalController.java: 100 Attack Vector
LOW Log_Forging /api/api-ingest/ingest-external/src/main/java/fr/gouv/vitamui/ingest/external/server/rest/IngestExternalController.java: 117 Attack Vector
LOW Log_Forging /api/api-pastis/pastis-external/src/main/java/fr/gouv/vitamui/pastis/server/rest/PastisController.java: 126 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 171 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 150 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 121 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 94 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 75 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 49 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 30 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 12 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 311 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 337 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 362 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 383 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 193 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 218 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 238 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 264 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy-gateway.conf.js: 290 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unchecked_Input_for_Loop_Condition /api/api-archive-search/archive-search-external/src/main/java/fr/gouv/vitamui/archives/search/external/server/rest/ArchivesSearchExternalController.java: 100
MEDIUM Unchecked_Input_for_Loop_Condition /api/api-collect/collect-external/src/main/java/fr/gouv/vitamui/collect/external/server/rest/TransactionArchiveUnitExternalController.java: 94
LOW Log_Forging /api/api-ingest/ingest-external/src/main/java/fr/gouv/vitamui/ingest/external/server/rest/IngestExternalController.java: 117
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy.conf.js: 94
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy.conf.js: 75
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy.conf.js: 49
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy.conf.js: 30
LOW Use_Of_Hardcoded_Password /ui/ui-frontend/proxy.conf.js: 12

@GiooDev GiooDev changed the title Api gateway Epic #12041: Migration apps to API Gateway Mar 4, 2024
@bbenaissa bbenaissa force-pushed the api-gateway branch 2 times, most recently from ac375db to de71877 Compare March 4, 2024 13:09
bbenaissa and others added 8 commits March 4, 2024 14:33
@bbenaissa
Story #11949: migrate archive search to api gateway
ca85633
@ebernard
Story #11965: migrate pastis to api gateway
c7a2e3a
@ebernard
Remove cp-cli dependency as cp-cli is deprecated (see screendriver/cp…
17f3ff1 
…-cli#62 (comment))
@ebernard
Use a newer version, compatible with mac
f08ff34
@ebernard
Ensure that scripts are sorted by version, as the difference filter d…
1a1cd92 
…oes not guarantee the order (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/difference_filter.html#ansible-collections-ansible-builtin-difference-filter - "Items in the resulting list are returned in arbitrary order")
@ebernard
Story #11964: Migrate Collect to API Gateway
dada9d6
@ebernard
Story #12413: allow ldap auth to coexist with api gw
46b3fcc
Story#11963: migrate ingest application to api gateway mode, and fix …
382b75e 
…surrogation, and other bugs
@bbenaissa bbenaissa merged commit 7935323 into develop Mar 4, 2024
3 checks passed
@bbenaissa bbenaissa deleted the api-gateway branch March 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Regzox Regzox Regzox approved these changes

@GiooDev GiooDev GiooDev approved these changes

@pyXelians pyXelians Awaiting requested review from pyXelians

@marob marob Awaiting requested review from marob

@ebernard ebernard Awaiting requested review from ebernard

Assignees

@bbenaissa bbenaissa

Labels
enhancement New feature or request OPS REVIEW Mandatory if deployment/ directory is modified. VAS VAS contribution
Projects
None yet
Milestone
IT 132
Development

Successfully merging this pull request may close these issues.
5 participants
@bbenaissa @vitam-devops @GiooDev @Regzox @ebernard