Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story #13302: Added ability to select Vitam's components to deploy in legacy mode #2062

Conversation

achoubiemohamed
Copy link
Collaborator

… legacy mode

Description

Description des modifications

Type de changement

Indiquer le ou les types de changements

  • Build
  • Ansiblerie

Documentation

Indiquer la documentation mise à jour

  • Quels sont les nouvelles documentations ?
  • Quels sont les modifications existantes ?
  • Quels sont les documentations ou sections de documentations supprimés ?

Tests

Indiquer comment le code à été testé (manuel, environnement, TU, etc)

  • manuel
  • environnement
  • TU

Migration

Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire

Checklist

Sélectionner les éléments de la checklist

  • Mon code suit le style de code de ce projet.
  • J'ai commenté mon code, en particulier dans les classes et les méthodes difficile à comprendre.
  • J'ai fait les changements correspondant dans la documentation RAML.
  • J'ai fait les changements correspondant dans la documentation Métier.
  • J'ai fait les changements correspondant dans la documentation Technique.
  • J'ai rajouté les tests unitaires vérifiant mes fonctionnalités.
  • J'ai rajouté les tests de non régression vérifiant mes fonctionnalités.
  • Les tests unitaires nouveaux et existants passent avec succès localement.
  • Toutes les dépendances ont été mergées en priorité

Contributeur

Indiquer qui a développé cette fonctionnalité

  • VAS (Vitam Accessible en Service)
  • CEA (Commissariat à l'énergie atomique et aux énergies alternatives)

@achoubiemohamed achoubiemohamed changed the title Story #13302: Added ability to select Vitam's components to deploy in… WIP: Story #13302: Added ability to select Vitam's components to deploy in… Sep 26, 2024
@achoubiemohamed achoubiemohamed force-pushed the story_13301_allow_container_deployment_in_production branch from f014d28 to 57dd143 Compare September 26, 2024 13:48
@GiooDev GiooDev added the OPS REVIEW Mandatory if deployment/ directory is modified. label Sep 27, 2024
@GiooDev GiooDev added this to the IT 142 milestone Sep 27, 2024
@GiooDev GiooDev self-requested a review September 27, 2024 13:58
@GiooDev GiooDev changed the title WIP: Story #13302: Added ability to select Vitam's components to deploy in… WIP: Story #13302: Added ability to select Vitam's components to deploy in legacy mode Sep 27, 2024
@GiooDev GiooDev marked this pull request as draft September 27, 2024 13:58
@GiooDev GiooDev changed the title WIP: Story #13302: Added ability to select Vitam's components to deploy in legacy mode Story #13302: Added ability to select Vitam's components to deploy in legacy mode Sep 27, 2024
@achoubiemohamed achoubiemohamed force-pushed the story_13301_allow_container_deployment_in_production branch 9 times, most recently from f3bb6fb to d9896de Compare October 3, 2024 08:49
@achoubiemohamed achoubiemohamed force-pushed the story_13301_allow_container_deployment_in_production branch 4 times, most recently from aacbf74 to 823f2f7 Compare October 7, 2024 15:50
@vitam-prg
Copy link
Collaborator

vitam-prg commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Detailsec8dd3e8-1f60-4745-8807-b31ae6595fb0

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 25 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /docker-compose.yml: 26 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 25 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 26 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /vitam-recette.yml: 57 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /vitam-dev.yml: 27 Container has sensitive host directory mounted as a volume
HIGH Volume Has Sensitive Host Directory /vitam-recette.yml: 20 Container has sensitive host directory mounted as a volume
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 55 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 157 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 152 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 37 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 98 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Package Version /install.yml: 1 Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 40
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 160
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 58
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 155
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 101
LOW Unpinned Actions Full Length Commit SHA /build-and-test.yml: 14
LOW Unpinned Package Version /install.yml: 6

@achoubiemohamed achoubiemohamed force-pushed the story_13301_allow_container_deployment_in_production branch from 823f2f7 to 4845b04 Compare October 8, 2024 08:03
@achoubiemohamed achoubiemohamed marked this pull request as ready for review October 8, 2024 08:04
@achoubiemohamed achoubiemohamed merged commit 74f026c into develop Oct 8, 2024
5 of 6 checks passed
@achoubiemohamed achoubiemohamed deleted the story_13301_allow_container_deployment_in_production branch October 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OPS REVIEW Mandatory if deployment/ directory is modified.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants