Skip to content

Routes project link and feedback refactor #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: develop
Choose a base branch
from
Open

Routes project link and feedback refactor #87

wants to merge 40 commits into from

Conversation

petak5
Copy link
Member

@petak5 petak5 commented Jul 9, 2020

No description provided.

petak5 added 30 commits June 29, 2020 19:52
@petak5
Optionally can get JWT timeout time from environment file
b95e0fc
@petak5
Formatting fixes
2295466
@petak5
Don't create new DB session
27571b5
@petak5
Add info about setting JWT token timeout to README
1a7feea
@petak5
Fixed and made more verbose JWT token timeout environment variable se…
38b6c99 
…tting
@petak5
Refactored create project route
23d8aec
@petak5
Fix typos in response messages
5536927
@petak5
Update project route refactor
f266f5e
@petak5
Get projects routes refactor
beccc65
@petak5
Delete project refactor
8f4a042
@petak5
Fix possible error with multiple parameters with the same name being …
8716f16 
…passed to function
@petak5
Add session rollback to create project controller when failed
90575b2
@petak5
Update project tests after routes refactor
bce06a1
@petak5
Fixed delete project test
6fc6801
@petak5
Fix usage message for tests
946bebc
@petak5
Remove get all users test
2326e61
@petak5
Create project link
c6290ab
@petak5
Update project link
312c6bf
@petak5
Delete project link
7f24957
@petak5
Remove get all project links route and related code
8673dfa
@petak5
Remove get all project feedbacks route
002f832
@petak5
Create project feedback
0434d6f
@petak5
Delete project feedback
4c54d7a
@petak5
Rename user_id to author_id in ProjectFeedback
0937e9a
@petak5
Get link_id from path in delete project feedback route
a25807f
@petak5
Fix update project link route request body structure
056f7a0
@petak5
Fix create project link route request body structure
af528e2
@petak5
Get project id from path in delete project route
da079a9
@petak5
Change get project(s) routes to /project/<id> and /project/all
93196a5
@petak5
Merge branch 'routes_project_refactor' into routes_project_link_and_f…
8915bbe 
…eedback_refactor
@petak5 petak5 added this to the Release 1.0 milestone Jul 9, 2020
This was linked to issues Jul 9, 2020
Remove ids from **project** update and delete routes #68
Open
Rename projects routes to project #70
Open
Return more detailed response from controllers #72
Open
@petak5 petak5 requested review from a user, cgeopapa and marter11 July 9, 2020 20:48
marter11
marter11 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@marter11 marter11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Notice: maybe at the delete_project the db.session.rollback is needed if we delete everything related to the project before check the existence of the project itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marter11 marter11 marter11 approved these changes

@cgeopapa cgeopapa Awaiting requested review from cgeopapa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

Return more detailed response from controllers Rename projects routes to project Remove ids from **project** update and delete routes
2 participants
@petak5 @marter11