Skip to content

feat: benefits section implementation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ztest95
Copy link

@ztest95 ztest95 commented Mar 27, 2025

about this pr:
b78f7df

  • cards.tsx is from shadcn, but with dashed border to follow the card component design we have
  • featurecards.tsx build on top of cards.tsx, and this is the one on used on benefits section
  • decided to just opt with a simple dashed border, instead of using two divs, even though it is not as accurate as the one in figma (length of dash) as I also couldn't really make the other solution perfect for different screens
  • icons (svgs) in the feature cards are added as react components

4eb71d9

  • changed to w-full instead of w-screen as this caused a horizontal scroll
  • updated layout to fix bg color not covering entire screen on xl screens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant