-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add device tree samsung-winner #113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am by no means able to control what happens here or force you but please, do everyone a favor and squash those commits into a few less commits |
hi bro, check the line in readme.md: | samsung-winner | xxx | xxx | xxx | |
all things looks fine now, thanks for pr. |
please reply me if you still have something to add, otherwise this pr will be merged in 24hours. |
Hi bro, thanks fo commit, I will update dtb in the evening
sob., 23 wrz 2023, 03:06 użytkownik Kancy Joe ***@***.***>
napisał:
… please reply me if you still have something to add, otherwise this pr will
be merged in 24hours.
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6NMKI3TUU4LTB7VYUICZTX3YY2HANCNFSM6AAAAAA45ASVFI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi bro the same problem for build (nuget installed,
mono installed)
sob., 23 wrz 2023, 08:19 użytkownik Igor Ostrovskyy ***@***.***>
napisał:
… Hi bro, thanks fo commit, I will update dtb in the evening
sob., 23 wrz 2023, 03:06 użytkownik Kancy Joe ***@***.***>
napisał:
> please reply me if you still have something to add, otherwise this pr
> will be merged in 24hours.
>
> —
> Reply to this email directly, view it on GitHub
> <#113 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC6NMKI3TUU4LTB7VYUICZTX3YY2HANCNFSM6AAAAAA45ASVFI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
u can just build all 8150 devices in github action actually
Sunflower2333.
________________________________
From: Ost268 ***@***.***>
Sent: Sunday, September 24, 2023 4:18:29 AM
To: woa-msmnile/msmnilePkg ***@***.***>
Cc: Kancy Joe ***@***.***>; Comment ***@***.***>
Subject: Re: [woa-msmnile/msmnilePkg] add device tree samsung-winner (PR #113)
Hi bro the same problem for build (nuget installed,
mono installed)
sob., 23 wrz 2023, 08:19 użytkownik Igor Ostrovskyy ***@***.***>
napisał:
Hi bro, thanks fo commit, I will update dtb in the evening
sob., 23 wrz 2023, 03:06 użytkownik Kancy Joe ***@***.***>
napisał:
> please reply me if you still have something to add, otherwise this pr
> will be merged in 24hours.
>
> —
> Reply to this email directly, view it on GitHub
> <#113 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC6NMKI3TUU4LTB7VYUICZTX3YY2HANCNFSM6AAAAAA45ASVFI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub<#113 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AM4FVLI6DE4I5ZAUSLSHGPDX347ZLANCNFSM6AAAAAA45ASVFI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
i think you should add these commits in next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.