Feat: Set timer resolution (1ms) #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfgHiatus
requested changes
Oct 21, 2024
BabbleApp/babbleapp.py
Outdated
| rc = c_int(winmm.timeBeginPeriod(1)) | ||
| if rc.value != 0: | ||
| # TIMEERR_NOCANDO = 97 | ||
| print(f"[WARN] Failed to set timer resolution: {rc.value}") |
There was a problem hiding this comment.
Please use our new locale system for text!
BabbleApp/babbleapp.py
Outdated
| try: | ||
| winmm = windll.winmm | ||
| except OSError: | ||
| #print("[DEBUG] Failed to load winmm.dll") |
There was a problem hiding this comment.
Please use our new locale system for text!
|
Added some feedback to your PR! Thanks |
dfgHiatus
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for this is the frequent use of "time.time()" which can cause unexpected behaviour, for example in "camera.py":
Line
self.fps = 1 / (self.newft - self.prevft)can trigger "ZeroDivisionError" if the loop runs faster than timer resolution.In above case we should handle the possible zero division like so:
self.fps = 1 / (self.newft - self.prevft) if self.newft > self.prevft else 0Or we could use
time.perf_counter()instead, but it's not worth ~3x the cycles?I do a similar check on my fork along with using a exponential moving average instead.
TLDR:
Rather than hope that user has a program open that requests a higher timer resolution. Do it ourselves?