Linux support #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigglesss
commented
Sep 16, 2022
| const element = manifest.Files[index]; | ||
| // Cross-platform support requires us to use path.join, but there's no function in Node | ||
| // that can handle a mixture of Windows+Linux path separators, so we reconstruct the path locally. | ||
| const normalisedPath = path.join(...element.Path.split('\\')) |
There was a problem hiding this comment.
This is a bit nasty. It would be easier if the manifest server returned an array instead of a string, or just used linux format paths, as Node has build in support for normalising Linux paths (it doesn't seem to be able to do the opposite).
path.join('foo', 'baz/foo');
// 'foo/baz/foo' on OSX and Linux
// 'foo\\baz\\foo' on Windows
added 2 commits
September 16, 2022 17:19
Use wine when launching on linux platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone could run
yarn makeon Windows and check the resulting EXE to confirm that I haven't broken the Windows build, that would be appreciated. The Linux build configs refuse to acceptproductNameoverrides (instead defaulting to the root package.json name), so I had to change the defaultproductNameto matchnameand update the squirrel config instead, which may not work.Fixed hashing/updating logic for Linux
Minor syntax changes to fix some errors/warnings I was getting
Built-in wine support, when launching the game from the Launcher.
Automatically switch to OpenGL in the Config.WTF unless the user has DXVK installed. Technically, DXVK is the best solution for Linux, but OpenGL works out of the box wth a simple Config.WTF change, and supports all platforms.