update docs #567
Merged
update docs #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ghostloda <78798447@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
archlitchi
reviewed
Oct 23, 2024
There was a problem hiding this comment.
这里可以加一句，“当值为0时，代表使用全部的显存”
There was a problem hiding this comment.
这里可以加一句，“当值为0时，代表使用全部的显存”
好的，不过百分之那边也不设置的时候才会使用全部显存。
archlitchi
reviewed
Oct 23, 2024
There was a problem hiding this comment.
i think add "'0' means use 100% device memory" here would be better
Signed-off-by: ghostloda <78798447@qq.com>
|
thanks for your fixing:) /approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
update defaultMem value from 5000 to 0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: