fix: nvidia-device-plugin no version info #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/cc @archlitchi |
|
/lgtm |
haitwang-cloud
pushed a commit
to haitwang-cloud/HAMi
that referenced
this pull request
Jan 10, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
haitwang-cloud
pushed a commit
to haitwang-cloud/HAMi
that referenced
this pull request
Jan 10, 2025
…and processing fix: improve UUID parsing and error handling in ExtractMigTemplatesFromUUID function refactor: update test cases for ExtractMigTemplatesFromUUID with comprehensive scenarios chore: clean up imports and enhance test readability across various test files Signed-off-by: haitwang-cloud <haitao_wht@outlook.com> fix: nvidia-device-plugin no version info (Project-HAMi#779) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: haitwang-cloud <haitao_wht@outlook.com> Implement initial E2E test suite setup (Project-HAMi#775) Signed-off-by: wen.rui <wen.rui@daocloud.io> Signed-off-by: haitwang-cloud <haitao_wht@outlook.com> Draft E2E test design (Project-HAMi#633) Signed-off-by: Rei1010 <wen.rui@daocloud.io> Signed-off-by: wen.rui <wen.rui@daocloud.io> Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #777
Special notes for your reviewer:
The image created by GitHub Action does not have VERSION information.
The reason is that the VERSION was not passed during the make all phase.
Does this PR introduce a user-facing change?: