Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Mednist Bundle #263

Merged
merged 9 commits into from
Feb 19, 2023
Merged

Mednist Bundle #263

merged 9 commits into from
Feb 19, 2023

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Feb 16, 2023

Addresses #29 at least partially.

This bundle definition provides the same example training scheme as the "Denoising Diffusion Probabilistic Models with MedNIST Dataset" notebook. It uses YAML files to define scripts and configurations including multiple GPU support. This is a template of a number of (to me at least) good practices that can be used for other networks and training schemes in general and not just for generative models.

I've stuck to the original notebook closely but if it's more helpful there are more features I would add for logging and loss/validation visualisation.

I have also not added a pre-trained model file yet since this is still private and the best practice is to upload the file somewhere public and use a large_files.yml file in the model zoo to specify where along with hashes. This can be done for the actual model zoo upload later.

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod requested a review from Warvito February 16, 2023 22:21
@Warvito Warvito linked an issue Feb 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@Warvito Warvito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great example, Eric! It will help a lot in the implementation of other model pretrained models. I added just a few suggestions

ericspod and others added 5 commits February 18, 2023 01:57
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod merged commit aadd90f into main Feb 19, 2023
@Warvito Warvito deleted the mednist_bundle branch March 1, 2023 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tutorials using MONAI Bundle to define the generative models
2 participants