This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Warvito
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great example, Eric! It will help a lot in the implementation of other model pretrained models. I added just a few suggestions
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Co-authored-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29 at least partially.
This bundle definition provides the same example training scheme as the "Denoising Diffusion Probabilistic Models with MedNIST Dataset" notebook. It uses YAML files to define scripts and configurations including multiple GPU support. This is a template of a number of (to me at least) good practices that can be used for other networks and training schemes in general and not just for generative models.
I've stuck to the original notebook closely but if it's more helpful there are more features I would add for logging and loss/validation visualisation.
I have also not added a pre-trained model file yet since this is still private and the best practice is to upload the file somewhere public and use a
large_files.yml
file in the model zoo to specify where along with hashes. This can be done for the actual model zoo upload later.