Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker image build fails frequently #1252

Closed
wyli opened this issue Nov 17, 2020 · 3 comments · Fixed by #1253 or #1270
Closed

docker image build fails frequently #1252

wyli opened this issue Nov 17, 2020 · 3 comments · Fixed by #1253 or #1270
Assignees
Labels

Comments

@wyli
Copy link
Contributor

wyli commented Nov 17, 2020

Describe the bug
recently the docker image build on DockerHub fails frequently without specific error msg:
Screenshot 2020-11-17 at 12 10 07
this might due to longer building time or larger disk space requirement, need some investigations here.

Additional context
https://hub.docker.com/repository/docker/projectmonai/monai/builds

@wyli wyli added the CI/CD label Nov 17, 2020
@wyli wyli self-assigned this Nov 17, 2020
wyli added a commit to wyli/MONAI that referenced this issue Nov 17, 2020
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this issue Nov 17, 2020
2 tasks
@IsaacYangSLA IsaacYangSLA self-assigned this Nov 17, 2020
@IsaacYangSLA
Copy link
Contributor

IsaacYangSLA commented Nov 17, 2020

The same docker build process took about 4 minutes in build_only runner (https://github.com/Project-MONAI/MONAI/runs/1413950455?check_suite_focus=true). If docker hub has computation/memory quota, we can remove the build process used in docker hub and add a docker push into our CI script after the local_docker step is finished. Since both docker hub and local_docker build the image from Dockerfile, the resulting container images will be the same.

@wyli
Copy link
Contributor Author

wyli commented Nov 17, 2020

that sounds great @IsaacYangSLA, thanks! could you send a PR to extend the local docker step? perhaps could incorporate the changes in #1253 if they are useful.

the webhook will also trigger build for a tagging push (for milestone releases), so for now let's not completely cancel the webhook

wyli added a commit that referenced this issue Nov 19, 2020
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: Isaac Yang <isaacy@nvidia.com>
@danielschulz
Copy link
Contributor

The same docker build process took about 4 minutes in build_only runner (https://github.com/Project-MONAI/MONAI/runs/1413950455?check_suite_focus=true). If docker hub has computation/memory quota, we can remove the build process used in docker hub and add a docker push into our CI script after the local_docker step is finished. Since both docker hub and local_docker build the image from Dockerfile, the resulting container images will be the same.

I basically just did that to solve the issue w/ rate limits on hub.docker.com. Here's my PR:
#1406

That's how I'd solve the issue:
https://github.com/Project-MONAI/MONAI/pull/1406/files#diff-2b7a275119830a358bfee2c8a847ea3d1f46f4e2ad8e6239e76d60275e322021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants