Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activation function a parameter of ResBlock #3414

Closed
patricio-astudillo opened this issue Nov 29, 2021 · 4 comments · Fixed by #3419
Closed

Make activation function a parameter of ResBlock #3414

patricio-astudillo opened this issue Nov 29, 2021 · 4 comments · Fixed by #3419
Assignees
Labels
enhancement New feature or request

Comments

@patricio-astudillo
Copy link
Contributor

The activation function of a ResBlock is currently hard coded. It would be nice if we could set it ourselves to a specific activation function.

self.relu = Act[Act.RELU](inplace=True)

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 29, 2021

Hi @yiheng-wang-nv ,

Could you please help take a look at this ticket?

Thanks in advance.

@Nic-Ma Nic-Ma added the enhancement New feature or request label Nov 29, 2021
@Nic-Ma Nic-Ma added this to the Bug Fixes or Misc improvements milestone Nov 29, 2021
@yiheng-wang-nv
Copy link
Contributor

Hi @patricio-astudillo @Nic-Ma , sure I will add this parameter recently.

@patricio-astudillo
Copy link
Contributor Author

I can add it too if you'd like and make a pull request?

@yiheng-wang-nv
Copy link
Contributor

Hi @patricio-astudillo , sure, it would be nice if you can submit a pull request for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants