Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing the activation function of the SegResNet to the Residual Blocks #3419

Merged
merged 12 commits into from
Dec 1, 2021

Conversation

patricio-astudillo
Copy link
Contributor

@patricio-astudillo patricio-astudillo commented Nov 30, 2021

Fixes #3414

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

patricio-astudillo and others added 4 commits November 30, 2021 09:06
making the activation function a parameter to the class of the ResBlock
@patricio-astudillo
Copy link
Contributor Author

@yiheng-wang-nv or @Nic-Ma would it be possible to review this PR please?

@wyli
Copy link
Contributor

wyli commented Nov 30, 2021

thanks, could you please sign the commits? https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work

(the section on preparing pull requests also provides some useful information about running unit tests locally: https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#preparing-pull-requests)

Patricio Astudillo and others added 5 commits November 30, 2021 10:08
Signed-off-by: Patricio Astudillo <patricio.astudillo@robovision.ai>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Dec 1, 2021

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from yiheng-wang-nv December 1, 2021 10:51
@wyli
Copy link
Contributor

wyli commented Dec 1, 2021

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've made minor updates and locally verified that the mmar model loading tests work fine.

@wyli wyli enabled auto-merge (squash) December 1, 2021 11:23
@wyli
Copy link
Contributor

wyli commented Dec 1, 2021

/build

@wyli wyli merged commit 0b077da into Project-MONAI:dev Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make activation function a parameter of ResBlock
3 participants