-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing the activation function of the SegResNet to the Residual Blocks #3419
Conversation
making the activation function a parameter to the class of the ResBlock
Update segresnet_block.py
@yiheng-wang-nv or @Nic-Ma would it be possible to review this PR please? |
thanks, could you please sign the commits? https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work (the section on preparing pull requests also provides some useful information about running unit tests locally: https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#preparing-pull-requests) |
for more information, see https://pre-commit.ci
Signed-off-by: Nic Ma <nma@nvidia.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I've made minor updates and locally verified that the mmar model loading tests work fine.
/build |
Fixes #3414
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.