Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the num_workers in ThreadDataLoader #3763

Closed
Nic-Ma opened this issue Feb 3, 2022 · 0 comments · Fixed by #3770
Closed

Clarify the num_workers in ThreadDataLoader #3763

Nic-Ma opened this issue Feb 3, 2022 · 0 comments · Fixed by #3770
Assignees
@Nic-Ma
Labels
enhancement New feature or request
Milestone
Bug Fixes or Misc...

Comments

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Feb 3, 2022

Is your feature request related to a problem? Please describe.
When I was introducing GPU transforms and the associated ThreadDataLoader to users, got several times feedback about the num_workers arg, which is confusing that users think it means the multi-threads in ThreadDataLoader, but actually it's the multi-processing workers of PyTorch DataLoader.
Would be nice to clarify this arg and the use cases.
@Nic-Ma Nic-Ma added the enhancement New feature or request label Feb 3, 2022
@Nic-Ma Nic-Ma added this to the Bug Fixes or Misc improvements milestone Feb 3, 2022
@Nic-Ma Nic-Ma self-assigned this Feb 3, 2022
@Nic-Ma Nic-Ma added this to MONAI 0.9 Feb 3, 2022
@Nic-Ma Nic-Ma mentioned this issue Feb 5, 2022
Merged
7 tasks
@wyli wyli closed this as completed in #3770 Feb 6, 2022
@wyli wyli moved this to Done in MONAI 0.9 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nic-Ma Nic-Ma

Labels
enhancement New feature or request
Projects
No open projects
MONAI 0.9
Status: Done
Milestone
Bug Fixes or Misc improvements
Development

Successfully merging a pull request may close this issue.

3763 Enhance the doc of ThreadDataLoader for num_workers Nic-Ma/MONAI
1 participant
@Nic-Ma