Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3763 Enhance the doc of ThreadDataLoader for num_workers #3770

Merged
merged 8 commits into from
Feb 6, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 5, 2022

Fixes #3763 .

Description

This PR enhanced the doc of ThreadDataLoader to clarify num_workers arg and the typical usage.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Sorry, something went wrong.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 5, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 5, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 5, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, wyli and rijobro February 5, 2022 16:59
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 6, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 6, 2022

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 6, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 6, 2022

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) February 6, 2022 14:08
@wyli
Copy link
Contributor

wyli commented Feb 6, 2022

/build

2 similar comments
@wyli
Copy link
Contributor

wyli commented Feb 6, 2022

/build

@wyli
Copy link
Contributor

wyli commented Feb 6, 2022

/build

@wyli wyli merged commit b61db79 into Project-MONAI:dev Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the num_workers in ThreadDataLoader
2 participants