-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FROC metrics for 3D data #5172
Comments
The only method that needs to be adapted is:
And it seems impossible to introduce 3D support without breaking the API. I could submit a PR if we agree on an API. E.g.:
this one would support arbitrary dimensions |
thanks, for backward compatibility, we can create |
Fixes #5172 . ### Description Implementation of FROC metric in ND ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [X] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [X] In-line docstrings updated. --------- Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Is your feature request related to a problem? Please describe.
To be used on 3D data such as MRI, CT images
Additional context
Notice that the current froc metrics only support 2d data, wonder if it is possible to extend it to 3d data? Thanks
The text was updated successfully, but these errors were encountered: