Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts directory to Python search directories automatically and avoid using PYTHONPATH #6722

Closed
wyli opened this issue Jul 14, 2023 · 1 comment · Fixed by #6910
Closed

Add scripts directory to Python search directories automatically and avoid using PYTHONPATH #6722

wyli opened this issue Jul 14, 2023 · 1 comment · Fixed by #6910
Assignees
@KumoLiu
Labels
Feature request

Comments

@wyli
Copy link
Contributor

wyli commented Jul 14, 2023

No description provided.

@wyli wyli converted this from a draft issue Jul 14, 2023
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 28, 2023

I think we have already added the scripts directory automatically in the bundle, not sure what this means here.
https://github.com/Project-MONAI/model-zoo/blob/e6ecc282d5490f1b66ccd16948b94cd5590152e4/models/pathology_nuclei_classification/configs/evaluate.json#L69

@KumoLiu KumoLiu moved this from Bundle Todo to In Progress in MONAI v1.3 Aug 29, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Aug 29, 2023
@KumoLiu
fix Project-MONAI#6722
623c58e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this issue Aug 29, 2023
Merged
7 tasks
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Aug 30, 2023
@KumoLiu
fix Project-MONAI#6722
bd3364b 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in MONAI v1.3 Aug 31, 2023
wyli pushed a commit that referenced this issue Aug 31, 2023
@KumoLiu
Add bundle root directory to Python search directories automatically (#…
be4e1f5 
…6910)

Fixes #6722 .

### Description
Add scripts directory to Python search directories automatically in the
`run` function in `ConfigWorkflow`.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
Feature request
Projects
No open projects
MONAI v1.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bundle root directory to Python search directories automatically KumoLiu/MONAI
2 participants
@wyli @KumoLiu