Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetaProterties and update load API #6834

Closed
KumoLiu opened this issue Aug 8, 2023 · 0 comments · Fixed by #6835
Closed

Add MetaProterties and update load API #6834

KumoLiu opened this issue Aug 8, 2023 · 0 comments · Fixed by #6835

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 8, 2023

Part of #6726

  • Add create_workflow, which can create a BundleWorkflow by specifying config_file or workflow_name (which can support Python-based bundle)
  • Add MetaProterties, now users can directly call meta information from an initialized BundleWorkflow
  • Update load API
@KumoLiu KumoLiu moved this to In Progress in MONAI v1.3 Aug 10, 2023
@KumoLiu KumoLiu changed the title from_bundle API: support get properties and metadata from bundle get API: support get properties and metadata from bundle Aug 14, 2023
@KumoLiu KumoLiu changed the title get API: support get properties and metadata from bundle Add MetaProterties and update load API Aug 29, 2023
wyli pushed a commit that referenced this issue Aug 30, 2023
Fixes #6834.

### Description
This PR introduces the idea of `BundleManager`, with `get` as one of the
methods, to avoid repeatedly instantiating `ConfigWorkflow`.

**usage**
```
bundle = BundleManager("spleen_ct_segmentation")
bundle.get("network_data_format")

or

bundle.get(property="train_preprocessing")
```

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in MONAI v1.3 Aug 30, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Aug 30, 2023
Fixes Project-MONAI#6834.

### Description
This PR introduces the idea of `BundleManager`, with `get` as one of the
methods, to avoid repeatedly instantiating `ConfigWorkflow`.

**usage**
```
bundle = BundleManager("spleen_ct_segmentation")
bundle.get("network_data_format")

or

bundle.get(property="train_preprocessing")
```

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants