Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New errors after flake8-bugbear upgrade #7396

Closed
KumoLiu opened this issue Jan 17, 2024 · 0 comments · Fixed by #7397
Closed

New errors after flake8-bugbear upgrade #7396

KumoLiu opened this issue Jan 17, 2024 · 0 comments · Fixed by #7397

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 17, 2024

new issue from flake8-bugbear: 23.1.15

[2024-01-16T16:07:31.298Z] 7.0.0 (flake8-bugbear: 24.1.16, flake8-comprehensions: 3.14.0, mccabe: 0.7.0,
[2024-01-16T16:07:31.299Z] pep8-naming: 0.13.3, pycodestyle: 2.11.1, pyflakes: 3.2.0) CPython 3.8.10 on
[2024-01-16T16:07:31.299Z] Linux
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/auto3dseg/data_analyzer.py:344:13: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/auto3dseg/ensemble_builder.py:219:17: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/auto3dseg/utils.py:55:13: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/detection/metrics/coco.py:544:5: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/nnunet/nnunetv2_runner.py:200:9: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/nnunet/nnunetv2_runner.py:278:9: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/config/deviceconfig.py:121:5: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/inferers/inferer.py:501:9: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/monai/utils/tf32.py:44:5: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_flexible_unet.py:43:24: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_invertd.py:117:43: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_invertd.py:117:63: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_invertd.py:122:46: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_invertd.py:122:66: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_resnet.py:202:13: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_retinanet.py:146:9: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_retinanet.py:179:9: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] /home/jenkins/agent/workspace/MONAI-premerge/monai/tests/utils.py:192:13: B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] 13    B036 Don't except `BaseException` unless you plan to re-raise it.
[2024-01-16T16:07:37.815Z] 5     B038 editing a loop's mutable iterable often leads to unexpected results/bugs
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Jan 17, 2024
@KumoLiu
fix Project-MONAI#7396
dd8a46a 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu mentioned this issue Jan 17, 2024
Merged
7 tasks
KumoLiu added a commit that referenced this issue Jan 18, 2024
@KumoLiu
Fix Premerge (#7397)
78295c7 
Fixes #7396


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
@KumoLiu @juampatronics
Fix Premerge (Project-MONAI#7397)
7e7d278 
Fixes Project-MONAI#7396

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
@KumoLiu @Yu0610
Fix Premerge (Project-MONAI#7397)
b28f8b5 
Fixes Project-MONAI#7396

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Premerge KumoLiu/MONAI
1 participant
@KumoLiu