Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate error message in regression.py #7610

Closed
rizvi-ha opened this issue Apr 4, 2024 · 0 comments · Fixed by #7612
Closed

Inaccurate error message in regression.py #7610

rizvi-ha opened this issue Apr 4, 2024 · 0 comments · Fixed by #7612

Comments

@rizvi-ha
Copy link

rizvi-ha commented Apr 4, 2024

Describe the bug

On line 306 of monai.metrics.regression, the printed error message states that y_pred should have 4 dimensions when in fact the surrounding if-statement is looking for the case where y_pred should have 5 dimensions. This confused me because I got an error message saying:

"y_pred should have 4 dimensions (batch, channel, height, width, depth) when using 3 spatial dimensions, got 4."

Expected behavior

All that needs to be changed is the number 4 to a 5

KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Apr 5, 2024
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu mentioned this issue Apr 5, 2024
7 tasks
KumoLiu added a commit that referenced this issue Apr 8, 2024
Fixes #7610


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant