Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Not Using Pytype in PR tests #8022

Closed
ericspod opened this issue Aug 16, 2024 · 1 comment · Fixed by #8025
Closed

Consider Not Using Pytype in PR tests #8022

ericspod opened this issue Aug 16, 2024 · 1 comment · Fixed by #8025

Comments

@ericspod
Copy link
Member

Is your feature request related to a problem? Please describe.
Pytype is very slow and there's not much that seems to be done about this. One of the checks in PRs is to run this for everything which significantly slows down the review process occasionally. Would we be better off moving this to an occasional test instead? Typically if mypy is ok with code pytype is as well so there's not that much value.

Describe the solution you'd like
Move pytype to be weekly test or something like this. Optionally we could test with pyright but this is throwing up a lot of errors currently owing to our import system (which may benefit from a revamp itself).
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Aug 19, 2024
@KumoLiu
fix Project-MONAI#8022
de48151 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu mentioned this issue Aug 19, 2024
Merged
7 tasks
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 19, 2024

Hi @ericspod, as suggested, I set the pytype test as not required for each PR and added the format test to weekly-preview.

rcremese pushed a commit to rcremese/MONAI that referenced this issue Sep 2, 2024
@KumoLiu @rcremese
Move PyType test to weekly test (Project-MONAI#8025)
71c27f4 
Fixes Project-MONAI#8022

### Description

- Add format test to weekly test
- Set pytype test as not required in each PR
- Add packaging in weekly-preview pipeline

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move PyType test to weekly test KumoLiu/MONAI
2 participants
@ericspod @KumoLiu