Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1378 Add output_dtype to NiftiSaver and SegmentationSaver #1394

Merged
merged 2 commits into from
Dec 28, 2020
Merged

1378 Add output_dtype to NiftiSaver and SegmentationSaver #1394

merged 2 commits into from
Dec 28, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Dec 23, 2020

Fixes #1378 .

Description

This PR added output_dtype arg to NiftiSaver and SegmentationSaver to align with nifti_writer.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 2 commits December 23, 2020 23:05
@Nic-Ma
Merge pull request #2 from Project-MONAI/master
dc2381b 
merge mater
@Nic-Ma
[DLMED] add output_dtype
e85c5f4 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 23, 2020

/black

wyli
wyli approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit f20e132 into Project-MONAI:master Dec 28, 2020
@Nic-Ma Nic-Ma deleted the 1378-add-niftisaver-data-type branch July 2, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SegmentationSaver fails if dtype is np.uint8
2 participants
@Nic-Ma @wyli