Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1442 add LocalNet #1447

Merged
merged 37 commits into from
Jan 15, 2021
Merged

1442 add LocalNet #1447

merged 37 commits into from
Jan 15, 2021

Conversation

kate-sann5100
Copy link
Collaborator

@kate-sann5100 kate-sann5100 commented Jan 13, 2021 •
edited
Loading

Fixes #1442 .

Description

Add LocalNet.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

kate-sann5100 and others added 30 commits January 6, 2021 21:15
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master'
7579659
@kate-sann5100
1412 add local normalized cross correlation
ce61c38 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 add unit test and documentation
5cf91d0 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 fix bug
9376195 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 reformat code
ac36a9f 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 debug type check
ed6c28b 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 use separable filter for speed
43c2f35 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge branch 'master' into 1412-local-normalized-cross-correlation
9cc4438
@kate-sann5100
1412 update Union import route
f76e3f0 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1412 fix negative bug and add smooth_nr
50940c2 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@wyli
remove temp. code
cab9b0b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@kate-sann5100
1412 reformat code
6db2528 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge remote-tracking branch 'origin/1412-local-normalized-cross-corr…
a3dd503 
…elation' into 1412-local-normalized-cross-correlation
@kate-sann5100
1412 remove redundant import
af4cab5 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master'
c3b21c2
@kate-sann5100
Merge branch '1412-local-normalized-cross-correlation'
46124da
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master'
a74e61c
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master' into 1442-localnet
0396f20
@kate-sann5100
1442 add localnet
8cc4f88 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 add test
3455ee8 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 add documentation
16011d7 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 add typing
a99782b 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
Merge remote-tracking branch 'Project-MONAI/master' into 1442-localnet
ca5baa2
@kate-sann5100
1442 reformat
3772414 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
c2373e9 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
99b3fac 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
9437fb3 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
7ef82c5 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
c510806 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
61691e5 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
kate-sann5100 and others added 6 commits January 14, 2021 15:20
@kate-sann5100
1442 reformat
1399f68 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
6329035 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
6e8b60e 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 reformat
c51d597 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@kate-sann5100
1442 remove initializsation
2f18619 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@wyli
Merge branch 'master' into 1442-localnet
7bc6e51
@wyli wyli closed this Jan 14, 2021
@wyli
Copy link
Contributor

wyli commented Jan 14, 2021

/black

@wyli wyli reopened this Jan 14, 2021
wyli
wyli reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! please update the factory calls, the rest looks good to me.

monai/networks/blocks/localnet_block.py Outdated Show resolved Hide resolved
@kate-sann5100
1442 update factory calls
786eb07 
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
@wyli wyli merged commit e115d6c into Project-MONAI:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LocalNet
2 participants
@kate-sann5100 @wyli